[PATCH] m68k/atari: Remove obsolete keyboard_tasklet scheduling

[Geert Uytterhoeven]

If CONFIG_VT=n:

arch/m68k/atari/built-in.o: In function `atari_keyboard_interrupt':
atakeyb.c:(.text+0x1846): undefined reference to `keyboard_tasklet'
atakeyb.c:(.text+0x1852): undefined reference to `keyboard_tasklet'

I think the keyboard_tasklet scheduling is no longer needed, as I
believe it's handled by drivers/tty/vt/keyboard.c based on events
received from the input subsystem. So just remove it.

Signed-off-by: Geert Uytterhoeven <***@linux-m68k.org>
---
Not tested on real hardware. ARAnyM doesn't have keyboard LEDs.

arch/m68k/atari/atakeyb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
index 95022b04b62d..1e2be1d34635 100644
--- a/arch/m68k/atari/atakeyb.c
+++ b/arch/m68k/atari/atakeyb.c
@@ -170,7 +170,6 @@ repeat:
if (acia_stat & ACIA_RDRF) {
/* received a character */
scancode = acia.key_data; /* get it or reset the ACIA, I'll get it! */
- tasklet_schedule(&keyboard_tasklet);
interpret_scancode:
switch (kb_state.state) {
case KEYBOARD:

[Michael Schmitz]

Hi Geert

Post by Geert Uytterhoeven
atakeyb.c:(.text+0x1846): undefined reference to `keyboard_tasklet'
atakeyb.c:(.text+0x1852): undefined reference to `keyboard_tasklet'

Has keyboard_tasklet gone for good, or just been conditionalized on
CONFIG_VT?

Post by Geert Uytterhoeven
I think the keyboard_tasklet scheduling is no longer needed, as I
believe it's handled by drivers/tty/vt/keyboard.c based on events
received from the input subsystem. So just remove it.

I'd like to test this on real hardware (though ARAnyM does emulate the
keyboard ACIA IIRC - if you had a working keyboard there I should find
no different),

Cheers,

Michael

Post by Geert Uytterhoeven
---
Not tested on real hardware. ARAnyM doesn't have keyboard LEDs.
arch/m68k/atari/atakeyb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
index 95022b04b62d..1e2be1d34635 100644
--- a/arch/m68k/atari/atakeyb.c
+++ b/arch/m68k/atari/atakeyb.c
if (acia_stat & ACIA_RDRF) {
/* received a character */
scancode = acia.key_data; /* get it or reset the ACIA, I'll get it! */
- tasklet_schedule(&keyboard_tasklet);
switch (kb_state.state) {

[Geert Uytterhoeven]

Hi Michael,

Post by Michael Schmitz

Post by Geert Uytterhoeven
atakeyb.c:(.text+0x1846): undefined reference to `keyboard_tasklet'
atakeyb.c:(.text+0x1852): undefined reference to `keyboard_tasklet'

Has keyboard_tasklet gone for good, or just been conditionalized on
CONFIG_VT?

Conditionalized. It's in drivers/tty/vt/keyboard.c.
Note that this was from a randconfig build.

Post by Michael Schmitz

Post by Geert Uytterhoeven
I think the keyboard_tasklet scheduling is no longer needed, as I
believe it's handled by drivers/tty/vt/keyboard.c based on events
received from the input subsystem. So just remove it.

I'd like to test this on real hardware (though ARAnyM does emulate the
keyboard ACIA IIRC - if you had a working keyboard there I should find no
different),

Keyboard was still working on ARAnyM.
But AFAICU, the keyboard_tasklet is used for the LED state only.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ***@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds