Discussion:
[PATCH] video: valkyriefb: Fix unused variable warning in set_valkyrie_clock()
Geert Uytterhoeven
2014-09-14 09:48:30 UTC
Permalink
If CONFIG_ADB_CUDA=3Dn:

drivers/video/fbdev/valkyriefb.c: In function =E2=80=98set_valkyrie_clo=
ck=E2=80=99:
drivers/video/fbdev/valkyriefb.c:267: warning: unused variable =E2=80=98=
i=E2=80=99
drivers/video/fbdev/valkyriefb.c:266: warning: unused variable =E2=80=98=
req=E2=80=99

Move the variable declarations inside the existing #ifdef section to fi=
x
this.

Signed-off-by: Geert Uytterhoeven <***@linux-m68k.org>
---
drivers/video/fbdev/valkyriefb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/val=
kyriefb.c
index 97cb9bd1d1dd..b6ed09f16355 100644
--- a/drivers/video/fbdev/valkyriefb.c
+++ b/drivers/video/fbdev/valkyriefb.c
@@ -263,10 +263,10 @@ static inline int valkyrie_vram_reqd(int video_mo=
de, int color_mode)
=20
static void set_valkyrie_clock(unsigned char *params)
{
+#ifdef CONFIG_ADB_CUDA
struct adb_request req;
int i;
=20
-#ifdef CONFIG_ADB_CUDA
for (i =3D 0; i < 3; ++i) {
cuda_request(&req, NULL, 5, CUDA_PACKET, CUDA_GET_SET_IIC,
0x50, i + 1, params[i]);
--=20
1.9.1
Tomi Valkeinen
2014-09-30 09:43:53 UTC
Permalink
drivers/video/fbdev/valkyriefb.c:267: warning: unused variable ‘i’
drivers/video/fbdev/valkyriefb.c:266: warning: unused variable ‘req’
Move the variable declarations inside the existing #ifdef section to fix
this.
---
drivers/video/fbdev/valkyriefb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c
index 97cb9bd1d1dd..b6ed09f16355 100644
--- a/drivers/video/fbdev/valkyriefb.c
+++ b/drivers/video/fbdev/valkyriefb.c
@@ -263,10 +263,10 @@ static inline int valkyrie_vram_reqd(int video_mode, int color_mode)
static void set_valkyrie_clock(unsigned char *params)
{
+#ifdef CONFIG_ADB_CUDA
struct adb_request req;
int i;
-#ifdef CONFIG_ADB_CUDA
for (i = 0; i < 3; ++i) {
cuda_request(&req, NULL, 5, CUDA_PACKET, CUDA_GET_SET_IIC,
0x50, i + 1, params[i]);
Thanks, queued for 3.18.

Tomi

Loading...